Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create GitHub Action(s) to process a PR of an NR1 Application #4

Closed
7 of 9 tasks
tangollama opened this issue Feb 27, 2020 · 2 comments
Closed
7 of 9 tasks

Create GitHub Action(s) to process a PR of an NR1 Application #4

tangollama opened this issue Feb 27, 2020 · 2 comments

Comments

@tangollama
Copy link
Contributor

tangollama commented Feb 27, 2020

On the initiation of a Pull Request:

@jbeveland27
Copy link
Contributor

These 2 steps are not going to be accomplished on pull_request.

Would need access to commit missing/incorrect uuid to the forked repo for this to work. Instead, this will only be done when PR is approved and merged.

There's no secure method for passing needed API keys to a forked repo (#8).

@jbeveland27
Copy link
Contributor

The catalog-pr Workflow now meets these requirements. Closing issue.

jbeveland27 added a commit that referenced this issue Apr 6, 2020
* feat: add nr1-browser-analyzer submodule

* feat: add nr1-cloud-optimize (#2) [skip publish]

* feat: add nr1-container-explorer submodule (#3) [skip publish]

* feat: add nr1-datalyzer submodule (#4) [skip publish]

Co-authored-by: Michael Frederick <[email protected]>
tangollama added a commit that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants