fix: Fixed queueing of logs from child loggers #2945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2945 +/- ##
===========================================
- Coverage 97.35% 79.58% -17.77%
===========================================
Files 317 307 -10
Lines 48619 47460 -1159
===========================================
- Hits 47331 37770 -9561
- Misses 1288 9690 +8402
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jsumners-nr
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It was discovered that components of the agent that rely on child loggers and adding logging from those child loggers before a root logger is configured crashes the agent. This is because the child logger did not get assigned a log queue. Once I assigned that, I realized it was missing the extras associated with a logger, most notably the component. This PR fixes both of those issues and adds tests to ensure that you can queue logs from a child logger and it gets the appropriate component in a given log like when the queue is flushed and logged accordingly.
Related Issues
Closes #2941