fix: Fixed api.getTraceMetadata to handle when there is an active transaction but not active segment
#2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransaction but not active segment
jsumners-nr
approved these changes
Feb 12, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2944 +/- ##
==========================================
- Coverage 97.35% 88.72% -8.63%
==========================================
Files 317 316 -1
Lines 48619 48610 -9
==========================================
- Hits 47331 43131 -4200
- Misses 1288 5479 +4191
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A regression existed from the refactor of 12.11.0. A PR(#2943) was opened around a gap in test coveraege around this
getTraceMetadatamethod. A customer had an active transaction but not segment. We assumed this could never happen, however this does happen at times due to context propagation breaking. This PR addresses this issue by handling of addingtraceIdandspanIdseparately. The customer experiencing this will still have invalid trace metadata(lacking a spanId) but that's a different issue.