Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Added regex note to sql obfuscator #2911

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2861.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.35%. Comparing base (559dc98) to head (691fa10).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   90.26%   97.35%   +7.09%     
==========================================
  Files         289      309      +20     
  Lines       45807    47423    +1616     
==========================================
+ Hits        41347    46170    +4823     
+ Misses       4460     1253    -3207     
Flag Coverage Δ
integration-tests-cjs-18.x 73.13% <100.00%> (+0.01%) ⬆️
integration-tests-cjs-20.x 73.13% <100.00%> (+0.01%) ⬆️
integration-tests-cjs-22.x 73.15% <100.00%> (+<0.01%) ⬆️
integration-tests-esm-18.x 49.83% <100.00%> (?)
integration-tests-esm-20.x 49.84% <100.00%> (+0.02%) ⬆️
integration-tests-esm-22.x 49.89% <100.00%> (+0.02%) ⬆️
unit-tests-18.x 89.10% <100.00%> (-0.02%) ⬇️
unit-tests-20.x 89.12% <100.00%> (+<0.01%) ⬆️
unit-tests-22.x 89.12% <100.00%> (+<0.01%) ⬆️
versioned-tests-18.x 79.22% <100.00%> (?)
versioned-tests-20.x 79.24% <100.00%> (?)
versioned-tests-22.x 79.24% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review January 29, 2025 18:22
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bizob2828 bizob2828 added the documentation Improvements or additions to documentation label Jan 29, 2025
@bizob2828 bizob2828 merged commit 1533111 into newrelic:main Jan 29, 2025
29 checks passed
@jsumners-nr jsumners-nr deleted the issue-2861 branch February 3, 2025 12:47
@github-actions github-actions bot mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Improve sql obfuscation regular expressions
2 participants