Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Restored the branch to test apollo-server-plugin to main #2879

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

bizob2828
Copy link
Member

Description

To get versioned tests to pass against apollo server plugin, there were changes needed like the agent from the segment/context manager refactor. This PR restores to the main branch as the work has been merged in newrelic/newrelic-node-apollo-server-plugin#337

How to Test

npm run versioned:external:major

@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.30%. Comparing base (73985ea) to head (da3a1c7).
Report is 3 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (73985ea) and HEAD (da3a1c7). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (73985ea) HEAD (da3a1c7)
unit-tests-20.x 1 0
unit-tests-22.x 1 0
integration-tests-cjs-20.x 1 0
integration-tests-cjs-22.x 1 0
unit-tests-18.x 1 0
integration-tests-esm-20.x 1 0
integration-tests-cjs-18.x 1 0
integration-tests-esm-18.x 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2879       +/-   ##
===========================================
- Coverage   97.40%   79.30%   -18.10%     
===========================================
  Files         308      289       -19     
  Lines       47369    45611     -1758     
===========================================
- Hits        46138    36172     -9966     
- Misses       1231     9439     +8208     
Flag Coverage Δ
integration-tests-cjs-18.x ?
integration-tests-cjs-20.x ?
integration-tests-cjs-22.x ?
integration-tests-esm-18.x ?
integration-tests-esm-20.x ?
integration-tests-esm-22.x 49.89% <ø> (ø)
unit-tests-18.x ?
unit-tests-20.x ?
unit-tests-22.x ?
versioned-tests-18.x 79.21% <ø> (-0.19%) ⬇️
versioned-tests-20.x 79.21% <ø> (-0.19%) ⬇️
versioned-tests-22.x 79.22% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 merged commit 978faab into newrelic:main Jan 15, 2025
28 of 29 checks passed
@bizob2828 bizob2828 deleted the update-external-branch branch January 15, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants