feat: Added entity linking attributes to aws-sdk v3 Lambda segments #2845
+167
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
…f account ID is undefined Signed-off-by: mrickard <[email protected]>
…egments recorded within a serverless context, as they're not required for linking the Lambda entity Signed-off-by: mrickard <[email protected]>
bizob2828
requested changes
Dec 18, 2024
…ower case Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
…ambda linking tests Signed-off-by: mrickard <[email protected]>
…e to differences in local and remote behavior Signed-off-by: mrickard <[email protected]>
bizob2828
approved these changes
Dec 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2845 +/- ##
==========================================
- Coverage 97.26% 97.20% -0.06%
==========================================
Files 294 295 +1
Lines 46405 46462 +57
==========================================
+ Hits 45135 45164 +29
- Misses 1270 1298 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
External Lambda functions invoked by a Node application result in external segments. In order for the entity to be linked, external segments need two additional attributes:
cloud.resource_idandcloud.platform. This PR adds middleware atinstrumentation/aws-sdk/v3/lambda.js(viainstrumentation/aws-sdk/v3/smithy-client.js) to add these attributes. This middleware adds the attributes only if the agent's config includes an AWS account ID defined ascloud.aws.account_id. The account ID referenced here should be the same as the AWS account ID hosting Lambda functions that will be invoked by the instrumented Node application.How to Test
There are two new tests in
test/versioned/aws-sdk-v3/lambda.test.js: one to test for these new attributes whencloud.aws.account_idis set on the agent config, and one to test for their absence whencloud.aws.account_idis not set.Related Issues
Closes #2829
Closes NR-348168