Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrumentation for fs.glob for node 22+ #2336

Closed
bizob2828 opened this issue Jul 9, 2024 · 1 comment · Fixed by #2369
Closed

Add instrumentation for fs.glob for node 22+ #2336

bizob2828 opened this issue Jul 9, 2024 · 1 comment · Fixed by #2369
Assignees

Comments

@bizob2828
Copy link
Member

Description

In #2304 I identified a useful method to add to our fs instrumentation. We purposely avoid instrumenting the sync methods because they are used in tight loops in other parts of core and frameworks so you’d get a pile of overhead and thousands of segment you don’t want (could potentially merge them but overhead maybe not worth it)

Acceptance Criteria

Add instrumentation for fs.glob in Node 22+

Design Consideration/Limitations

Why is this the route we should take to achieve our goal?
What can't be achieved within this story?

Dependencies

Do any other teams or parts of the New Relic product need to be considered?
Some common areas: UI, collector, documentation

Additional context

We need to add an integration test for this new method. Looking at the tests we could reduce a lot of boiler plate too, but up to the dev that takes this on

@workato-integration
Copy link

@bizob2828 bizob2828 moved this to Triage Needed: Unprioritized Features in Node.js Engineering Board Jul 15, 2024
@jsumners-nr jsumners-nr self-assigned this Jul 17, 2024
@jsumners-nr jsumners-nr moved this from Triage Needed: Unprioritized Features to In progress: Issues being worked on in Node.js Engineering Board Jul 17, 2024
@github-project-automation github-project-automation bot moved this from In progress: Issues being worked on to Done: Issues recently completed in Node.js Engineering Board Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants