Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spike]: Research additional instrumentation points in Node 22 #2304

Closed
bizob2828 opened this issue Jun 26, 2024 · 2 comments
Closed

[spike]: Research additional instrumentation points in Node 22 #2304

bizob2828 opened this issue Jun 26, 2024 · 2 comments
Assignees
Labels
points: 5 1-2 weeks

Comments

@bizob2828
Copy link
Member

Description

We need to dig into all the new additions to Node 22 and see if there's anything worth instrumenting. If so, cut tickets to address in the future.

@workato-integration
Copy link

@bizob2828 bizob2828 added points: 5 1-2 weeks and removed needs-triage labels Jul 9, 2024
@bizob2828 bizob2828 self-assigned this Jul 9, 2024
@bizob2828
Copy link
Member Author

Provided analysis in the Node 22 research doc

New Features / Potential Breakages

What’s New

WebSocket
The browser-compatible implementation of WebSocket, previously behind the flag --experimental-websocket, will be enabled by default. This provides a WebSocket client to Node.js without external dependencies.
Contributed by the Undici team and Aras Abbasi in #51594

We've had FRs for socket.io(1) but now that this is part of Std lib and is browser compatible WebScocket it might be worth investigating. The only issue I see here is when to start/end spans.

glob and globSync
This release adds to the node:fsmodule the functions glob and globSync for pattern matching. Developers can now utilize these functions for matching file paths based on specified patterns.
Contributed by Moshe Atlow #51912

We could add glob as a method to instrument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
points: 5 1-2 weeks
Projects
Archived in project
Development

No branches or pull requests

1 participant