add empty and null guard for Event #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-nr
suggested changes
Aug 21, 2020
There was a problem hiding this comment.
Thanks @tbradellis ! Please add a test to demonstrate both behaviors and this will be good to go. 🤘
tbradellis
force-pushed
the
bellis/guard-eventType
branch
from
45db95c to
e50e908
Compare
jkwatson
approved these changes
Aug 26, 2020
breedx-nr
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grabbing this:
#195
Just adds a check on the first Event constructor that has eventType as a parameter which will always be called or will have already been called if creating from an Event.