🎁 Run tests on Ruby 3.4.1 #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twas the week after Christmas and all through the CI, references to Ruby 3.3 as top version said a goodbye.
kaylareopelle
commented
Jan 3, 2025
SimpleCov Report
|
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
tannalynn
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 3.4.1 is out! This PR updates the CI to test the newest version and replaces the areas where we used Ruby 3.3 as our default version to Ruby 3.4.
Workflow dispatches to check:
https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12590713430https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12590853852(failing with base64 error)main, which is still pointing to the old Rails version. Perf tests ran locally just fine on the current branch. I think we're safe to test.Though other workflows were also updated, I don't want to trigger them. We'll have to keep an eye out for funny business the next time they run.