Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db explain plan refactor #2940

Merged
merged 13 commits into from
Nov 18, 2024
Merged

db explain plan refactor #2940

merged 13 commits into from
Nov 18, 2024

Conversation

fallwith
Copy link
Contributor

@fallwith fallwith commented Nov 7, 2024

  • DRY up the similar explain plan logic that exists in both the AR and AR subscriber instrumentation
  • support AR v7.2+ by making use of with_connection when available

Closes #2922

fallwith and others added 4 commits November 6, 2024 23:53
- DRY up the similar explain plan logic that exists in both the AR and
  AR subscriber instrumentation
- support AR v7.2+ by making use of `with_connection` when available
have the chain and prepend module files relatively include the main
instrumentation file
test refactors to match explain plan DRY refactor
@kaylareopelle kaylareopelle marked this pull request as ready for review November 15, 2024 00:52
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.87% 93%
Branch 69.76% 50%

@kaylareopelle kaylareopelle merged commit 584a84a into dev Nov 18, 2024
35 of 36 checks passed
@kaylareopelle kaylareopelle deleted the how_will_we_ever_explain_this branch November 18, 2024 19:09
@kaylareopelle kaylareopelle restored the how_will_we_ever_explain_this branch November 18, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Postgres and MySQL explain plan traces missing when agent is used with Rails v7.2+
3 participants