Enhanced AWS Lambda serverless functionality #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fallwith
commented
Aug 13, 2024
fallwith
commented
- Introduce support for parsing distributed tracing information for HTTP based trigger invocations of the instrumented Lambda function
- Both AWS API Gateway versions 1.0 and 2.0 are supported
- For web driven invocations of an instrumented function, categorize the invocation as being "web" based, and record relevant HTTP information including the method, URI, and status code post invocation.
- Recognize and report on fully 12 separate AWS resources that are capable of triggering a Lambda function invocation: ALB, API Gateway V1, API Gateway V2, CloudFront, CloudWatch Scheduler, DynamoStreams, Firehose, Kinesis, S3, SES, SNS, and SQS.
- If an AWS resource based trigger is identified, record at least the type of the resource and the relevant arn. For many resources, also record additional context specific information. For example, for an S3 based invocation, record the S3 bucket name.
- Introduce support for parsing distributed tracing information for HTTP based trigger invocations of the instrumented Lambda function - Both AWS API Gateway versions 1.0 and 2.0 are supported - For web driven invocations of an instrumented function, categorize the invocation as being "web" based, and record relevant HTTP information including the method, URI, and status code post invocation. - Recognize and report on fully 12 separate AWS resources that are capable of triggering a Lambda function invocation: ALB, API Gateway V1, API Gateway V2, CloudFront, CloudWatch Scheduler, DynamoStreams, Firehose, Kinesis, S3, SES, SNS, and SQS. - If an AWS resource based trigger is identified, record at least the type of the resource and the relevant arn. For many resources, also record additional context specific information. For example, for an S3 based invocation, record the S3 bucket name.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
- utilize the constant pointing to the JSON source file - only read from the JSON source file once
for the dozen AWS resources under test, require Ruby 3.2+
skip unless Ruby v3.2+ (minimum available AWS Lambda runtime)
constrain all relevant tests to Ruby 3.2+
don't destructively alter the hash - use #dup instead
Co-authored-by: Hannah Ramadan <[email protected]>
tense fix for lambda updates Co-authored-by: Kayla Reopelle <[email protected]>
use bullets for the lambda enhancements Co-authored-by: Kayla Reopelle <[email protected]>
remove `rescue` that was intended to be temporary
use `each_value` instead of `each` with `_key`
the serverless handler is only used with Ruby v3.2+, so only test with Ruby v3.2+
removed redundant freezing
SimpleCov Report
|
kaylareopelle
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.