CI: Grape Envfile tweaks #2717
Merged
CI: Grape Envfile tweaks #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Grape... - Simplify the stripping away of Bundler pessimistic locking syntax to get at a raw Grape version string - Require (as Grape itself does) Ruby v2.6+ for using the latest Grape
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
We need to give Rack <= v3.0 to Grape v1.x. We may have a Grape version string in play, or it might be nil. When it is nil, we can count on Grape 2 being used for Ruby 3+ and Grape 1 being used for Ruby 2. So key off of both the Grape version and Ruby version when deciding to force Rack v3.0.
rework grape/rack version pinning logic and comment
SimpleCov Report
|
hannahramadan
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Grape...
nilversions (signifying "latest") and looking at the Ruby version in play