hotfix: prevent exception in record_one_broadcast_with_new_relic #2510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-appere
requested review from
fallwith,
hannahramadan,
kaylareopelle and
tannalynn
as code owners
|
|
github-actions
bot
added
the
community
nathan-appere
force-pushed
the
hotfix/nil-exception
branch
2 times, most recently
from
145c152 to
7cac1f9
Compare
nathan-appere
force-pushed
the
hotfix/nil-exception
branch
from
7cac1f9 to
8f76e26
Compare
| yield | ||
| broadcasts.each { |broadcasted_logger| broadcasted_logger.instance_variable_set(:@skip_instrumenting, false) } | ||
| else | ||
| ::NewRelic::Agent.record_custom_event('NR Error - record_one_broadcast_with_new_relic - nil broadcasts', {}) |
There was a problem hiding this comment.
Is there a something you hoped to get out of using record_custom_event?
We'd typically log an error instead, something like:
Suggested change
| ::NewRelic::Agent.record_custom_event('NR Error - record_one_broadcast_with_new_relic - nil broadcasts', {}) | |
| NewRelic::Agent.logger.error('Error recording broadcasted logger') |
|
Hi @nathan-appere! Thank you so much for this contribution. I've left one small comment and we will need the Contributor License Agreement signed before merging ◡̈ |
|
Hey @hannahramadan thanks for having a look, I ended up not deploying as it seems a bit dangerous to have a Rails version with random errors 🤔 |
tannalynn
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
Describe the changes present in the pull request
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist