Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHANGELOG update #2498

Merged
merged 3 commits into from
Mar 13, 2024
Merged

CHANGELOG update #2498

merged 3 commits into from
Mar 13, 2024

Conversation

hannahramadan
Copy link
Contributor

CHANGELOG update for community member-submitted PR #2475

@hannahramadan hannahramadan marked this pull request as ready for review March 8, 2024 23:28
kaylareopelle
kaylareopelle previously approved these changes Mar 9, 2024
CHANGELOG.md Outdated
@@ -4,6 +4,10 @@

Version <dev> hardens the browser agent insertion logic to better proactively anticipate errors.

- **Feature: Store tracer state on thread-level**

A new configuration option, `thread_local_tracer_state`, stores New Relic's tracer state on the thread-level, as opposed to the default fiber-level storage. This configuration is turned off by default. Thanks to community member [@markiz](https://github.com/markiz) who contributed the idea, code, configuration option, and tests for this new feature! [PR#2475](https://github.com/newrelic/newrelic-ruby-agent/pull/2475).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A new configuration option, `thread_local_tracer_state`, stores New Relic's tracer state on the thread-level, as opposed to the default fiber-level storage. This configuration is turned off by default. Thanks to community member [@markiz](https://github.com/markiz) who contributed the idea, code, configuration option, and tests for this new feature! [PR#2475](https://github.com/newrelic/newrelic-ruby-agent/pull/2475).
A new configuration option, `thread_local_tracer_state`, stores New Relic's tracer state on the thread-level, as opposed to the default fiber-level storage. This configuration is turned off by default. Our thanks go to community member [@markiz](https://github.com/markiz) who contributed the idea, code, configuration option, and tests for this new feature! [PR#2475](https://github.com/newrelic/newrelic-ruby-agent/pull/2475).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to leave this entry out of the version summary on line 5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I did not! I'll update—great catch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
Copy link
Contributor

github-actions bot commented Mar 9, 2024

SimpleCov Report

Coverage Threshold
Line 93.75% 93%
Branch 71.81% 71%

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Hannah!

@hannahramadan hannahramadan merged commit 5a5bf73 into dev Mar 13, 2024
28 checks passed
@hannahramadan hannahramadan deleted the update_changelog_with_community_pr branch March 13, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants