Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ruby version from 3.3.0-rc1 to 3.3.0 #2381

Merged
merged 4 commits into from
Jan 2, 2024
Merged

bump ruby version from 3.3.0-rc1 to 3.3.0 #2381

merged 4 commits into from
Jan 2, 2024

Conversation

tannalynn
Copy link
Contributor

Use the official release of ruby version 3.3.0

kaylareopelle
kaylareopelle reviewed Jan 2, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line references 3.2.2. Should it reference 3.3.0?

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tannalynn
Copy link
Contributor Author

This line references 3.2.2. Should it reference 3.3.0?

oh yeah for sure, thank you i missed that one
should be updated now!

kaylareopelle
kaylareopelle approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦄

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

SimpleCov Report

Coverage Threshold
Line 93.68% 94%
Branch 71.82% 82%

@tannalynn tannalynn merged commit b2d1c99 into dev Jan 2, 2024
27 of 28 checks passed
@tannalynn tannalynn deleted the bump_ruby_version branch January 2, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@fallwith fallwith Awaiting requested review from fallwith

@hannahramadan hannahramadan Awaiting requested review from hannahramadan hannahramadan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tannalynn @kaylareopelle