Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails edge can only run on ruby 3.1 and above #2380

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

tannalynn
Copy link
Contributor

Our nightly Ci is failing on 2.7 and 3.0 because of a bundler error with the rails edge env tests.

Because every version of rails depends on Ruby >= 3.1.0
  and Gemfile depends on rails >= 0,
  Ruby >= 3.1.0 is required.
So, because current Ruby version is = 3.0.6,
  version solving has failed.
Could not find compatible versions

Since rails edge needs 3.1+, I've removed the rails edge tests from 2.7 and 3.0 in our ci_cron

kaylareopelle
kaylareopelle previously approved these changes Jan 2, 2024
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@tannalynn tannalynn merged commit 20c2151 into dev Jan 2, 2024
27 checks passed
Copy link
Contributor

github-actions bot commented Jan 2, 2024

SimpleCov Report

Coverage Threshold
Line 94.23% 94%
Branch 82.8% 82%

@tannalynn tannalynn deleted the rails_edge_only_3_1_plus branch November 1, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants