Rename bin/newrelic -> bin/newrelic_rpm and remove older bin/newrelic_cmd references and binstub #2307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This addresses the issue opened here where there's currently a naming conflict with
newrelic-cli
and the Ruby agent if both are installed.It will require the
newrelic
binstub to be removed in a future major release before the actual name collision issue is solved.It also removes the older binstub for
newrelic_cmd
when a previous rename was done, as such this has the potential to be a breaking change for anyone not moved over to the new name.I've left the version number just a
xxx
as I'm unsure what version this will be merged into. Happy to update it to whatever, or leave that to y'all when it gets merged!Reviewer Checklist