Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename bin/newrelic -> bin/newrelic_rpm and remove older bin/newrelic_cmd references and binstub #2307

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

dinsley
Copy link
Contributor

@dinsley dinsley commented Nov 2, 2023

Overview

This addresses the issue opened here where there's currently a naming conflict with newrelic-cli and the Ruby agent if both are installed.

It will require the newrelic binstub to be removed in a future major release before the actual name collision issue is solved.

It also removes the older binstub for newrelic_cmd when a previous rename was done, as such this has the potential to be a breaking change for anyone not moved over to the new name.

I've left the version number just a xxx as I'm unsure what version this will be merged into. Happy to update it to whatever, or leave that to y'all when it gets merged!

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Nov 2, 2023
@fallwith
Copy link
Contributor

fallwith commented Nov 2, 2023

Thanks @dinsley for the cleanup and help with getting the project ready for the binary rename in a future major version release!

@fallwith fallwith merged commit 718d03e into newrelic:dev Nov 2, 2023
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants