Ethon: focus on return_code for errors #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For an instance of `Ethon::Easy`, consider a `#return_code` result not equal to `:ok` to be the indicator of an error instead of the `#response_code` being equal to `0`. With direct Ethon usage, these equality checks seem interchangeable but with Typhoeus the underyling easy object is left with a 0 for its response code on success.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
SimpleCov Report
|
kaylareopelle
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an instance of
Ethon::Easy, consider a#return_coderesult not equal to:okto be the indicator of an error instead of the#response_codebeing equal to0. With direct Ethon usage, these equality checks seem interchangeable but with Typhoeus the underyling easy object is left with a 0 for its response code on success.