Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning from sidekiq error handler #2261

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix deprecation warning from sidekiq error handler #2261

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/new_relic/agent/instrumentation/sidekiq.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@
end

if config.respond_to?(:error_handlers)
config.error_handlers << proc do |error, *_|
# Sidekiq 3.0.0 - 7.1.4 expect error_handlers to have 2 arguments
# Sidekiq 7.1.5+ expect error_handlers to have 3 arguments
config.error_handlers << proc do |error, _ctx, *_|
NewRelic::Agent.notice_error(error)
end
end
Expand Down
Loading