CI: Ruby 3.3.0-preview1 -> preview2 #2224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test with Ruby v3.3.0-preview2
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
kaylareopelle
previously approved these changes
Sep 18, 2023
Ruby 3.3.0-preview2 causes an '(eval ...' String to be yielded for a __FILE__ call performed within an `eval`. This String won't work properly in contexts that expect a String representing a valid filesystem path. We don't want to touch the .gemspec file for the sake of the test, and we don't yet want to refactor out the `eval` call that the test uses, so for now let's just make sure the test never has to deal with a __FILE__ call within the `eval`.
- replace __FILE__ for `envfile.rb` `instance_eval` calls - add `TODO` for __FILE__ swapping comments
SimpleCov Report
|
hannahramadan
approved these changes
Sep 19, 2023
kaylareopelle
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with Ruby v3.3.0-preview2
resolves #2223