Bugfix for code level metrics on active record classes #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
active record classes
and also not give a warning
tannalynn
requested review from
fallwith,
hannahramadan and
kaylareopelle
as code owners
fallwith
reviewed
Jun 21, 2023
Co-authored-by: James Bunch <[email protected]>
Co-authored-by: James Bunch <[email protected]>
fallwith
approved these changes
Jun 21, 2023
hannahramadan
approved these changes
Jun 21, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex the agent was using didn't account for the possibility of active record adding attributes to inspect, which resulted in trying to call
Object.const_getwith a class name that was like"Foo(id: integer, created_at: datetime, updated_at: datetime, name: string)", instead of just"Foo". This would cause an errorNameError: wrong constant namethat prevent code level metrics from gathering the information and would log a warning.Now, the regex will only grab word characters and :: for the name, preventing the
(....from being included as the class name.A test was also added to confirm this works properly and prevent issues in the future.
closes #2064