Create add_custom_log_attributes API #2069
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
force-pushed
the
custom-attributes-in-log-events
branch
2 times, most recently
from
a0b4f96 to
2bee8fc
Compare
kaylareopelle
commented
Jun 13, 2023
kaylareopelle
force-pushed
the
custom-attributes-in-log-events
branch
3 times, most recently
from
957dc60 to
5343b42
Compare
kaylareopelle
commented
Jun 14, 2023
kaylareopelle
requested review from
fallwith,
hannahramadan and
tannalynn
as code owners
fallwith
reviewed
Jun 14, 2023
tannalynn
reviewed
Jun 14, 2023
fallwith
previously approved these changes
Jun 15, 2023
|
If you’re up for it, I’d like to meet synchronously tomorrow to talk this through. I’ve been in a weird place emotionally today and I think my problems have seeped into this PR.
|
Sure thing. |
SimpleCov Report
|
This API allows users to add attributes to all log events for a given agent run. It accepts a single argument, a hash with key value pairs for the attributes. No more than 240 attributes can be added Keys must have less than 64 characters Values must have less than 4094 characters These attributes will be sent to the logs API in the "common"["attributes"] JSON block.
This was called already_warned_custom_attribute_count_limit. It is now called custom_attribute_limit_reached.
Co-authored-by: James Bunch <[email protected]>
Co-authored-by: James Bunch <[email protected]>
kaylareopelle
force-pushed
the
custom-attributes-in-log-events
branch
from
ceffdc1 to
a7ed284
Compare
|
See #2084 instead (git mistakes made on this PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2084 instead (git mistakes made on this PR)
The
NewRelic::Agent.add_custom_log_attributesAPI allows users to add attributes to all log events for a given agent run. It accepts key/value pairs as arguments.This API abides by log API documentation on limits, and event data:
These attributes will be sent to the logs API in the "common"["attributes"] JSON block.
Relates to: #1141