Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings in unit tests #1857

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Fix warnings in unit tests #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fbd9e0
fix warnings in unit tests
tannalynn Mar 6, 2023
4f4b507
update test regex to use %r{}
tannalynn Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/new_relic/agent/method_tracer_helpers_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def test_provides_accurate_info_for_an_instance_method
end
end

def test_provides_accurate_info_for_an_instance_method
def test_provides_accurate_info_for_a_private_instance_method
with_config(:'code_level_metrics.enabled' => true) do
info = NewRelic::Agent::MethodTracerHelpers.code_information(::The::Example, :private_method)

Expand Down
4 changes: 2 additions & 2 deletions test/new_relic/agent/tracer_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@ def test_thread_ids_included_when_enabled
Thread.new { 'woof' }.join
end

assert_match /Ruby\/Thread\/Thread\d+\/Fiber\d+/, txn.segments.last.name
assert_match %r{Ruby/Thread/Thread\d+/Fiber\d+}, txn.segments.last.name
end
end

Expand All @@ -413,7 +413,7 @@ def test_thread_ids_absent_when_disabled
Thread.new { 'woof' }.join
end

assert_match /Ruby\/Thread$/, txn.segments.last.name
assert_match %r{Ruby/Thread$}, txn.segments.last.name
end
end

Expand Down