Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RuboCop AbcSize driven updates: #1854

Merged
merged 1 commit into from
Mar 4, 2023
Merged

RuboCop AbcSize driven updates: #1854

merged 1 commit into from
Mar 4, 2023

Conversation

fallwith
Copy link
Contributor

@fallwith fallwith commented Mar 3, 2023

  • refactor the logger's call method to adhere to AbcSize guidelines
  • exempt Transaction.new
  • exempt curb's chain based instrumentation

helps with #1520

@fallwith
RuboCop AbcSize driven updates:
f37e879 
- refactor the logger's `call` method to adhere to AbcSize guidelines
- exempt `Transaction.new`
- exempt curb's chain based instrumentation
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2023

SimpleCov Report

Coverage Threshold
Line 93.98% 93%
Branch 85.49% 84%

tannalynn
tannalynn approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I like how it seems much neater now

@fallwith fallwith merged commit 68a3405 into dev Mar 4, 2023
@fallwith fallwith deleted the smurf_in_a_hammock branch March 4, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannalynn tannalynn tannalynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fallwith @tannalynn