Prevent undfined method error in Action Controller instrumentation #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
controller_path before calling
fallwith
reviewed
Feb 27, 2023
lib/new_relic/agent/instrumentation/action_controller_other_subscriber.rb
Outdated
Show resolved
Hide resolved
…bscriber.rb Co-authored-by: James Bunch <[email protected]>
fallwith
previously approved these changes
Feb 27, 2023
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
SimpleCov Report
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the action controller instrumentation was being called for a class that didn't respond to
controller_path, the agent would error when trying to create the metric name for the segment. Now it will always check to make sure that method will work before calling it. I also updated this section to use the safe navigation operator now that we only support ruby 2.4+.closes #1842