Remove DT warnings for sidekiq #1834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallwith
suggested changes
Feb 23, 2023
Co-authored-by: James Bunch <[email protected]>
fallwith
previously approved these changes
Feb 23, 2023
kaylareopelle
previously approved these changes
Feb 23, 2023
capitalize Distributed Tracing and Sidekiq. Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
fallwith
approved these changes
Feb 23, 2023
SimpleCov Report
|
This was referenced Mar 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent attempts to accept dt headers from sidekiq jobs if distributed tracing is enabled. If the jobs are not being created with an agent that also has dt enabled, then this can result in an excessive number of warnings in the agent logs. This change will make it so that we will only attempt to accept the headers if it is not empty.
closes #1725