Remove MessageBroker metric for ActiveJob #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahramadan
changed the title
hannahramadan
changed the title
tannalynn
approved these changes
Feb 8, 2023
fallwith
reviewed
Feb 8, 2023
| @@ -71,7 +71,7 @@ def self.perform(job, block) | |||
| end | |||
|
|
|||
| def self.run_in_trace(job, block, event) | |||
| trace_execution_scoped("MessageBroker/#{adapter}/Queue/#{event}/Named/#{job.queue_name}", | |||
| trace_execution_scoped("ActiveJob/#{adapter}/Queue/#{event}/Named/#{job.queue_name}", | |||
There was a problem hiding this comment.
Given the resulting change:
- MessageBroker/ActiveJob::Inline/Queue/Produce/MyQueueName
+ ActiveJob/ActiveJob::Inline/Queue/Produce/MyQueueNameI'm questioning the double ActiveJob string appearances. Maybe we should trim the leading ActiveJob:: string off of the adapter:
adapter.sub(/^ActiveJob::/, '')There was a problem hiding this comment.
I like this! The repetition isn't necessary. I've made this edit - thanks for providing the regex.
fallwith
approved these changes
Feb 9, 2023
fallwith
reviewed
Feb 9, 2023
spelling fix
fallwith
approved these changes
Feb 9, 2023
SimpleCov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ActiveJob isn't considered a MessageBroker. This PR cleans up naming and associated tests.
Closes #1151