Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all previously deprecated configuration options #1782

Merged
merged 30 commits into from
Feb 3, 2023
Merged

Remove all previously deprecated configuration options #1782

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
0d5dcd4
set apdex_t config to non public.
tannalynn Feb 1, 2023
68ed111
removed deprecated *.capture_attribute configs and
tannalynn Feb 1, 2023
99bd9b1
removed ignore_errors and updated tests
tannalynn Feb 1, 2023
dc34209
rubocop mad
tannalynn Feb 1, 2023
b8a3753
add rails and sinatra errors to default ignore
tannalynn Feb 1, 2023
09cba98
put back for test
tannalynn Feb 1, 2023
f0a0a0a
fix rails tests
tannalynn Feb 2, 2023
f6fb55d
rubocop mad
tannalynn Feb 2, 2023
3090435
removed analytic_event configs
tannalynn Feb 2, 2023
89b1744
fix transaction_events related tests
tannalynn Feb 2, 2023
5228552
put default ignored error classes back
tannalynn Feb 2, 2023
c29fbba
removed several instrumentation configs
tannalynn Feb 2, 2023
31f62cf
remove references to now deleted configs
tannalynn Feb 2, 2023
07bfb62
remove test for deleted config
tannalynn Feb 2, 2023
9f98858
remove deprecated configs and fix grape name
tannalynn Feb 2, 2023
c4af2a8
update instrumentation nameing
tannalynn Feb 2, 2023
64fbf76
remove decprecated net http prepend config
tannalynn Feb 2, 2023
f5d6b6b
update rails test using analytic_events config
tannalynn Feb 3, 2023
b012ff9
update rake test using deprecated config
tannalynn Feb 3, 2023
c60ca5a
remove keep_trying config
tannalynn Feb 3, 2023
b434d82
Merge branch 'major-release-9' into remove_deprecated_configs
tannalynn Feb 3, 2023
658762a
removed deprecated jobs capture_params configs
tannalynn Feb 3, 2023
fe38b65
remove resque test for deleted config
tannalynn Feb 3, 2023
405c81e
rubocop
tannalynn Feb 3, 2023
1f74d80
delete commented out code
tannalynn Feb 3, 2023
cd7a931
update sidekiq param tests
tannalynn Feb 3, 2023
5e50412
delete js_errors_beta config
tannalynn Feb 3, 2023
1c58bc1
remvoe whitespace
tannalynn Feb 3, 2023
37f9cfe
removed one of the CAT configs
tannalynn Feb 3, 2023
1bad6a7
Merge branch 'major-release-9' into remove_deprecated_configs
tannalynn Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/new_relic/agent/configuration/default_source.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,12 +370,12 @@ def self.enforce_fallback(allowed_values: nil, fallback: nil)
- a.third.event
DESCRIPTION
},
# this is only set via server side config
:apdex_t => {
:default => 0.5,
:public => true,
:public => false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it turns out this config is only deprecated for use in the newrelic.yml and env variables. This should only be set via server side config.
The agent however, still uses this value for things so we need to keep the config. So I've removed the deprecated tag and instead have made this a non public config option.

:type => Float,
:allowed_from_server => true,
:deprecated => true,
:description => 'For agent versions 3.5.0 or higher, [set your Apdex T via the New Relic UI](/docs/apm/new-relic-apm/apdex/changing-your-apdex-settings).'
},
:api_key => {
Expand Down