Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests and CHANGELOG entry for PR 1653 #1654

Merged
merged 4 commits into from
Nov 29, 2022
Merged

tests and CHANGELOG entry for PR 1653 #1654

merged 4 commits into from
Nov 29, 2022

Conversation

fallwith
Copy link
Contributor

here are some unit tests and a CHANGELOG entry for the community submission delivered by PR #1653

@fallwith
tests and CHANGELOG entry for PR 1653
675aa58 
here are some unit tests and a CHANGELOG entry for the community
submission delivered by PR 1653
kaylareopelle
kaylareopelle previously approved these changes Nov 29, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
test/new_relic/recipes/helpers/send_deployment_test.rb Outdated Show resolved Hide resolved
@kaylareopelle
Copy link
Contributor

Whoops, spoke too soon. Looks like there's an error related to the new tests in Ruby 2.2:

  4) Error:
Newrelic::SendDeploymentTest#test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value:
ArgumentError: wrong number of arguments (3 for 2)
    /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/new_relic/recipes/helpers/send_deployment_test.rb:29:in `block in test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value'
    /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/new_relic/recipes/helpers/send_deployment_test.rb:28:in `test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value'

@kaylareopelle kaylareopelle self-requested a review November 29, 2022 21:39
@fallwith @kaylareopelle
PR 1654 changelog feedback
746f4d4 
Capistrano based -> Capistrano-based

Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
fallwith and others added 2 commits November 29, 2022 13:43
@fallwith @kaylareopelle
PR 1653 feedback
75fa63c 
Changelog formatting: capitalization and hyphenation

Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
@fallwith
send_deployment_test.rb: require MiniTest v5
bcebb46 
these tests use the 3 argument MiniTest v5 `stub` syntax, so make sure
it is present (and for our CI suite, it will be as long as Ruby is at or
above v2.2)
@fallwith
Copy link
Contributor Author

Whoops, spoke too soon. Looks like there's an error related to the new tests in Ruby 2.2:

  4) Error:
Newrelic::SendDeploymentTest#test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value:
ArgumentError: wrong number of arguments (3 for 2)
    /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/new_relic/recipes/helpers/send_deployment_test.rb:29:in `block in test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value'
    /home/runner/work/newrelic-ruby-agent/newrelic-ruby-agent/test/new_relic/recipes/helpers/send_deployment_test.rb:28:in `test_fetch_changelog_initial_fetch_succeeds_and_using_scm_then_use_fetched_value'

@kaylareopelle addressed with bcebb46, thank you!

kaylareopelle
kaylareopelle approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, James!

@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.2% 93%
Branch 84.14% 84%

@fallwith fallwith merged commit e285e6c into dev Nov 29, 2022
@fallwith fallwith deleted the 1653_tests_and_changelog_entry branch November 29, 2022 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaylareopelle kaylareopelle kaylareopelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fallwith @kaylareopelle