Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rack-test references from Rails envfile #1648

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

hannahramadan
Copy link
Contributor

@hannahramadan hannahramadan commented Nov 22, 2022

Remove rack-test references from Rails envfile.

TODOs added with #1220
This issue was fixed by #1591
Closes #1442

Previously, tests failed when rack-test < 2 wasn't included. This issue
was resolved by PR#1591
@github-actions
Copy link
Contributor

SimpleCov Report

Coverage Threshold
Line 93.31% 93%
Branch 84.28% 84%

@hannahramadan hannahramadan marked this pull request as ready for review November 22, 2022 00:31
@hannahramadan hannahramadan merged commit 107cadb into dev Nov 22, 2022
@hannahramadan hannahramadan deleted the remove_racktest_from_rails_env branch January 20, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Rails Envfile TODO
2 participants