Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NewRelic::Agent::Tracer.in_transaction to identify category as a required kwarg #1587

Merged
merged 5 commits into from
Nov 4, 2022

Conversation

tannalynn
Copy link
Contributor

@tannalynn tannalynn commented Nov 2, 2022

Before contributing, please read our contributing guidelines and code of conduct.

Overview

When support for Ruby 2.0 was dropped in version 8.0.0 of the agent, the agent API methods were updated to use the required keyword argument feature built in to Ruby, rather than manually raising ArgumentError's. The API method NewRelic::Agent::Tracer.in_transaction removed the ArgumentError raised by the agent, but did not update the method arguments to identify category as a required keyword argument. resolves #1583

Submitter Checklist:

  • Include a link to the related GitHub issue, if applicable
  • Include a security review link, if applicable

Testing

The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
GitHub Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@tannalynn tannalynn marked this pull request as ready for review November 2, 2022 23:38
CHANGELOG.md Outdated Show resolved Hide resolved
tannalynn and others added 2 commits November 2, 2022 17:03
Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
NewRelic::Agent::Tracer.in_transaction
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

SimpleCov Report

Coverage Threshold
Line 93.28% 93%
Branch 84.18% 84%

…ewrelic/newrelic-ruby-agent into in_transaction_category_required_kwarg
@tannalynn tannalynn merged commit bade258 into dev Nov 4, 2022
@fallwith fallwith deleted the in_transaction_category_required_kwarg branch November 14, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined method `category' for NewRelic::Agent::Transaction:Class
3 participants