Update newrelic deployment command to support New Relic REST API v2
#1461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannalynn
changed the title
newrelic deployment to support New Relic REST API v2
tannalynn
changed the title
newrelic deployment to support New Relic REST API v2newrelic deployment command to support New Relic REST API v2
fallwith
suggested changes
Sep 23, 2022
There was a problem hiding this comment.
Very good stuff!!! This one has remained in limbo while different API teams hem and haw. It's great to have the agent itself be flexible and dynamically switch between the old and the new ways of doing things.
Left two requests for change:
- Use consistent capitalization of "API" (or "api") in the config param description
- "whne" typo
The other suggestions can be implemented or waived as you see fit. Great work!
fallwith
previously approved these changes
Sep 24, 2022
kaylareopelle
previously approved these changes
Sep 26, 2022
tannalynn
dismissed stale reviews from kaylareopelle and fallwith
via
5a2c8be
SimpleCov Report
|
kaylareopelle
approved these changes
Sep 26, 2022
kaylareopelle
added a commit
to kaylareopelle/docs-website
that referenced
this pull request
Nov 15, 2022
PR newrelic/newrelic-ruby-agent#1461 added support for deployment recording using a customer's user API key. This update was missing from the document.
tabathadelane
pushed a commit
to newrelic/docs-website
that referenced
this pull request
Nov 21, 2022
PR newrelic/newrelic-ruby-agent#1461 added support for deployment recording using a customer's user API key. This update was missing from the document.
This was referenced Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
The older deployment endpoint doesn't support newer license keys. There is an internal ticket for that endpoint to be updated, but in the meantime we have added support for the newer New Relic REST API v2 deployment endpoint. The config option
api_keymust be provided to the agent to use this newer endpoint.closes #715
Submitter Checklist:
Testing
The agent includes a suite of unit and functional tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here for our unit tests,
and here for our functional tests.
For most contributions it is strongly recommended to add additional tests which
exercise your changes.
Reviewer Checklist