Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.2+ cache invalidation stats #1088

Merged
merged 3 commits into from
Apr 16, 2022

Conversation

fallwith
Copy link
Contributor

@fallwith fallwith commented Apr 14, 2022

Ruby 3.2 uses a new RubyVM stat to track more fine grained constant
cache invalidation data. Sum the fine grained values together to produce
a Ruby 3.1 compatible value for now and leave a TODO for possibly
reporting the individual constant key/value pairs later.

Ruby 3.2 uses a new `RubyVM` stat to track more fine grained constant
cache invalidation data. Sum the fine grained values together to produce
a Ruby 3.1 compatible value for now and leave a TODO for possibly
reporting the individual constant key/value pairs later.
tannalynn
tannalynn previously approved these changes Apr 15, 2022
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Glad you noticed this change in ruby 3.2

kaylareopelle
kaylareopelle previously approved these changes Apr 15, 2022
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind creating an issue for the 3.2 todo as part of this merge so that we can track it when we start 3.2 work?

Other than that and the typos, this looks good to me!

lib/new_relic/agent/vm/mri_vm.rb Outdated Show resolved Hide resolved
lib/new_relic/agent/vm/mri_vm.rb Outdated Show resolved Hide resolved
Typo fix

Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
@fallwith fallwith dismissed stale reviews from kaylareopelle and tannalynn via 9abd4b1 April 15, 2022 23:06
Typo fix

Co-authored-by: Kayla Reopelle (she/her) <[email protected]>
@fallwith fallwith merged commit 1a14621 into dev Apr 16, 2022
@fallwith fallwith deleted the ruby32_cache_invalidation_support branch April 16, 2022 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants