Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add '/'.freeze to constants.rb #2153

Closed
hannahramadan opened this issue Aug 8, 2023 · 4 comments · Fixed by #2256
Closed

Add '/'.freeze to constants.rb #2153

hannahramadan opened this issue Aug 8, 2023 · 4 comments · Fixed by #2256
Assignees
@chahmedejaz
Labels
1 Story Point Estimate hacktoberfest help wanted oct-dec qtr Possible FY Q3 candidate

Comments

@hannahramadan
Copy link
Contributor

We have a few instances of '/'.freeze throughout the agent. We should add this to constants.rb and replace calls with this newly created constant.
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-149466

@kford-newrelic kford-newrelic added estimate Issue needing estimation 1 Story Point Estimate oct-dec qtr Possible FY Q3 candidate and removed estimate Issue needing estimation labels Aug 9, 2023
@kford-newrelic kford-newrelic moved this from Triage to To do in Ruby Engineering Board Oct 2, 2023
@chahmedejaz
Copy link
Contributor

Hey @kaylareopelle - I'd like to work on this issue, can you please assign it to me? Thanks :)

@fallwith
Copy link
Contributor

Thanks very much, @chahmedejaz! You have been assigned.

PLEASE NOTE that this project's use of /.freeze predates our adoption of using frozen strings by default. So when you define a new constant for /, you can leave off the .freeze part.

@chahmedejaz
Copy link
Contributor

Thanks @fallwith for the guidance. ❤️

chahmedejaz added a commit to chahmedejaz/newrelic-ruby-agent that referenced this issue Oct 12, 2023
@chahmedejaz
newrelic#2153, add slash and root constants
fddc57d
chahmedejaz added a commit to chahmedejaz/newrelic-ruby-agent that referenced this issue Oct 12, 2023
@chahmedejaz
newrelic#2153, replace SLASH and ROOT constants respectively
2b2e439
@chahmedejaz chahmedejaz mentioned this issue Oct 12, 2023
Merged
2 tasks
@github-project-automation github-project-automation bot moved this from To do to Code Complete/Done in Ruby Engineering Board Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chahmedejaz chahmedejaz

Labels
1 Story Point Estimate hacktoberfest help wanted oct-dec qtr Possible FY Q3 candidate
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add and Replace SLASH and ROOT constants chahmedejaz/newrelic-ruby-agent
5 participants
@fallwith @chahmedejaz @kford-newrelic @hannahramadan @kaylareopelle