Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Proactively check the code base for dead URLs #2126

Closed
fallwith opened this issue Jul 11, 2023 · 1 comment · Fixed by #2127
Closed

CI: Proactively check the code base for dead URLs #2126

fallwith opened this issue Jul 11, 2023 · 1 comment · Fixed by #2127
Assignees
@fallwith
Labels
integration Represents tracked integration test gaps

Comments

@fallwith
Copy link
Contributor

As suggested by #2121, we ought to proactively maintain healthy URLs.
@fallwith fallwith added the integration Represents tracked integration test gaps label Jul 11, 2023
@fallwith fallwith self-assigned this Jul 11, 2023
@workato-integration
Copy link

https://issues.newrelic.com/browse/NR-141074

fallwith added a commit that referenced this issue Jul 11, 2023
@fallwith
CI: Test for the health of all code base URLs
a14eb38 
- Add a new unit test class for testing the health of all URLs defined in the code base. See the comments in `test/new_relic/healthy_urls_test.rb` for more details
- Update `ci_cron.yml` to set a `CI_CRON` env var to true
- Update `.ruboycop.yml` to permit `throw` and `catch` calls without parens
- Add new `skip_unless_ci_cron` helper to permit tests to only run via `ci_cron.yml`
- Add new `skip_unless_newest_ruby` helper to permit tests to only run on the newest Ruby
- Add new `agent_root` helper to permit tests to quickly get to the agent root
- Fix 5 URLs that the new test caught

resolves #2126
@fallwith fallwith mentioned this issue Jul 11, 2023
Merged
@kford-newrelic kford-newrelic moved this to Code Complete/Done in Ruby Engineering Board Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallwith fallwith

Labels
integration Represents tracked integration test gaps
Projects
Ruby Engineering Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Test for the health of all code base URLs newrelic/newrelic-ruby-agent
1 participant
@fallwith