Skip to content

Commit

Permalink
prepend_rails_edge -> unshift_rails_edge
Browse files Browse the repository at this point in the history
use 'unshift' to avoid confusion with Ruby module prepend behavior
  • Loading branch information
fallwith committed Oct 11, 2023
1 parent 7b66163 commit a63e5cc
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/multiverse/lib/multiverse/envfile.rb
Original file line number Diff line number Diff line change
Expand Up @@ -133,9 +133,9 @@ def serialize?
@serialize
end

# add Rails Edge to the array of gem versions for testing,
# add Rails Edge to the beginning of the array of gem versions for testing,
# unless we're operating in a PR workflow context
def prepend_rails_edge(gem_version_array = [])
def unshift_rails_edge(gem_version_array = [])
return if ci_for_pr?

# Unshift Rails Edge (representing the latest GitHub primary branch
Expand Down
2 changes: 1 addition & 1 deletion test/multiverse/suites/active_record_pg/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ACTIVERECORD_VERSIONS = [
['5.0.0', 2.4, 2.7]
]

prepend_rails_edge(ACTIVERECORD_VERSIONS)
unshift_rails_edge(ACTIVERECORD_VERSIONS)

def gem_list(activerecord_version = nil)
<<~RB
Expand Down
2 changes: 1 addition & 1 deletion test/multiverse/suites/rails/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RAILS_VERSIONS = [
['4.2.11', 2.4, 2.4]
]

prepend_rails_edge(RAILS_VERSIONS)
unshift_rails_edge(RAILS_VERSIONS)

def haml_rails(rails_version = nil)
if rails_version && (
Expand Down
2 changes: 1 addition & 1 deletion test/multiverse/suites/rails_prepend/Envfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RAILS_VERSIONS = [
['4.2.0', 2.4, 2.4]
]

prepend_rails_edge(RAILS_VERSIONS)
unshift_rails_edge(RAILS_VERSIONS)

def gem_list(rails_version = nil)
# earlier thor errors, uncertain if they persist
Expand Down

0 comments on commit a63e5cc

Please sign in to comment.