Merge pull request #1591 from newrelic/NR-1222/rack-test-v2

NR-1222/rack-test-v2
newrelic · Nov 4, 2022 · 8867bbe · 8867bbe
2 parents 9a8d240 + ec0e9bb
commit 8867bbe
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/lib/new_relic/rack/browser_monitoring.rb b/lib/new_relic/rack/browser_monitoring.rb
@@ -104,6 +104,7 @@ def attachment?(headers)
       end
 
       def streaming?(env, headers)
+        # Chunked transfer encoding is a streaming data transfer mechanism available only in HTTP/1.1
         return true if headers && headers['Transfer-Encoding'] == 'chunked'
 
         defined?(ActionController::Live) &&

diff --git a/test/multiverse/suites/rails/Envfile b/test/multiverse/suites/rails/Envfile
@@ -44,7 +44,7 @@ def minitest_rails_version(rails_version = nil)
 end
 
 def pre2_rack_test
-  %Q(gem 'rack-test', '< 2')
+  %Q(gem 'rack-test')
 end
 
 def gem_list(rails_version = nil)

diff --git a/test/multiverse/suites/rails/action_controller_live_rum_test.rb b/test/multiverse/suites/rails/action_controller_live_rum_test.rb
@@ -42,7 +42,7 @@ def test_excludes_rum_instrumentation_when_streaming_with_action_controller_live
     end
 
     def test_excludes_rum_instrumentation_when_streaming_with_action_stream_true
-      get('/undead/brain_stream')
+      get('/undead/brain_stream', env: {'HTTP_VERSION' => 'HTTP/1.1'})
 
       assert_includes(response.body, UndeadController::RESPONSE_BODY)
       assert_not_includes(response.body, JS_LOADER)