Skip to content

Commit

Permalink
Merge pull request #2115 from newrelic/bugfix/2113-include-test-agent…
Browse files Browse the repository at this point in the history
…-helper

Include `test/agent_helper.rb` in build
  • Loading branch information
kaylareopelle authored Jul 10, 2023
2 parents adf27e9 + 7d69da5 commit 5e81f98
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# New Relic Ruby Agent Release Notes

## dev

Version <dev> of the agent fixes `NewRelic::Agent.require_test_helper`.

- **Bugfix: Fix NewRelic::Agent.require_test_helper**

Version 9.3.0 of the agent made a change to the files distributed with the gem. This change unintentionally broke the `NewRelic::Agent.require_test_helper` API by removing the `test/agent_helper.rb` file. The file has been added back to the gem. This change also removes the `lib/new_relic/build.rb` file from the list because it is no longer created with our current release process.

Our thanks go to [@ajesler](https://github.com/ajesler) for reporting this issue and writing a test for the bug. [Issue#2113](https://github.com/newrelic/newrelic-ruby-agent/issues/2113), [PR#2115](https://github.com/newrelic/newrelic-ruby-agent/pull/2115), [Issue#2117](https://github.com/newrelic/newrelic-ruby-agent/issues/2117), [PR#2118](https://github.com/newrelic/newrelic-ruby-agent/pull/2118)

## v9.3.0

Version 9.3.0 of the agent adds log-level filtering, adds custom attributes for log events, and updates instrumentation for Action Cable. It also provides fixes for how `Fiber` args are treated, Code-Level Metrics, unnecessary files being included in the gem, and `NewRelic::Agent::Logging::DecoratingFormatter#clear_tags!` being incorrectly private.
Expand Down
5 changes: 3 additions & 2 deletions newrelic_rpm.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ Gem::Specification.new do |s|

reject_list = File.read('./.build_ignore').split("\n")
file_list = `git ls-files -z`.split("\x0").reject { |f| reject_list.any? { |rf| f.start_with?(rf) } }
build_file_path = 'lib/new_relic/build.rb'
file_list << build_file_path if File.exist?(build_file_path)
# test/agent_helper.rb is a requirement for the NewRelic::Agent.require_test_helper public API
test_helper_path = 'test/agent_helper.rb'
file_list << test_helper_path
s.files = file_list

s.homepage = 'https://github.com/newrelic/rpm'
Expand Down

0 comments on commit 5e81f98

Please sign in to comment.