Disable Sending of ML Events by Default #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimPansino
approved these changes
Sep 18, 2023
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
…lic-python-agent into disable-ml-events-default
Codecov Report
@@ Coverage Diff @@
## develop-scikitlearn #923 +/- ##
====================================================
Coverage 81.74% 81.74%
====================================================
Files 190 190
Lines 19581 19581
Branches 3401 3401
====================================================
Hits 16006 16006
Misses 2593 2593
Partials 982 982
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TimPansino
requested changes
Sep 19, 2023
| @@ -717,7 +717,7 @@ def default_otlp_host(host): | |||
| _settings.transaction_events.attributes.include = [] | |||
|
|
|||
| _settings.custom_insights_events.enabled = True | |||
| _settings.ml_insights_events.enabled = True | |||
| _settings.ml_insights_events.enabled = False | |||
There was a problem hiding this comment.
Is this supposed to stay false too? Or just the global override setting?
There was a problem hiding this comment.
This one was supposed to stay False since we check this as a standalone setting in calls to record_ml_event and not in conjunction with machine_learning.enabled.
TimPansino
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the default value of
ml_insights_events.enabledtoFalseso it can be intentionally enabled by users who would like to send ML events to NR.