Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin virtualenv, fix pip arg deprecation & disable kafka tests #803

Merged
merged 4 commits into from
May 1, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-python-matrix/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ runs:
shell: bash
run: |
python3.10 -m pip install -U pip
python3.10 -m pip install -U wheel setuptools 'tox<4' virtualenv!=20.0.24
python3.10 -m pip install -U wheel setuptools 'tox<4' 'virtualenv<20.22.0'
144 changes: 72 additions & 72 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- elasticsearchserver08
- gearman
- grpc
- kafka
#- kafka
- libcurl
- memcached
- mongodb
Expand Down Expand Up @@ -534,77 +534,77 @@ jobs:
path: ./**/.coverage.*
retention-days: 1

kafka:
env:
TOTAL_GROUPS: 4

strategy:
fail-fast: false
matrix:
group-number: [1, 2, 3, 4]

runs-on: ubuntu-20.04
timeout-minutes: 30

services:
zookeeper:
image: bitnami/zookeeper:3.7
env:
ALLOW_ANONYMOUS_LOGIN: yes

ports:
- 2181:2181

kafka:
image: bitnami/kafka:3.2
ports:
- 8080:8080
- 8081:8081
env:
ALLOW_PLAINTEXT_LISTENER: yes
KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: true
KAFKA_CFG_LISTENERS: L1://:8080,L2://:8081
KAFKA_CFG_ADVERTISED_LISTENERS: L1://127.0.0.1:8080,L2://kafka:8081,
KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: L1:PLAINTEXT,L2:PLAINTEXT
KAFKA_CFG_INTER_BROKER_LISTENER_NAME: L2

steps:
- uses: actions/checkout@v3
- uses: ./.github/actions/setup-python-matrix

# Special case packages
- name: Install librdkafka-dev
run: |
# Use lsb-release to find the codename of Ubuntu to use to install the correct library name
sudo apt-get update
sudo ln -fs /usr/share/zoneinfo/America/Los_Angeles /etc/localtime
sudo apt-get install -y wget gnupg2 software-properties-common
sudo wget -qO - https://packages.confluent.io/deb/7.2/archive.key | sudo apt-key add -
sudo add-apt-repository "deb https://packages.confluent.io/clients/deb $(lsb_release -cs) main"
sudo apt-get update
sudo apt-get install -y librdkafka-dev/$(lsb_release -c | cut -f 2)

- name: Get Environments
id: get-envs
run: |
echo "::set-output name=envs::$(tox -l | grep "^${{ github.job }}\-" | ./.github/workflows/get-envs.py)"
env:
GROUP_NUMBER: ${{ matrix.group-number }}

- name: Test
run: |
tox -vv -e ${{ steps.get-envs.outputs.envs }}
env:
TOX_PARALLEL_NO_SPINNER: 1
PY_COLORS: 0

- name: Upload Coverage Artifacts
uses: actions/upload-artifact@v3
with:
name: coverage-${{ github.job }}-${{ strategy.job-index }}
path: ./**/.coverage.*
retention-days: 1
#kafka:
# env:
# TOTAL_GROUPS: 4

# strategy:
# fail-fast: false
# matrix:
# group-number: [1, 2, 3, 4]

# runs-on: ubuntu-20.04
# timeout-minutes: 30

# services:
# zookeeper:
# image: bitnami/zookeeper:3.7
# env:
# ALLOW_ANONYMOUS_LOGIN: yes

# ports:
# - 2181:2181

# kafka:
# image: bitnami/kafka:3.2
# ports:
# - 8080:8080
# - 8081:8081
# env:
# ALLOW_PLAINTEXT_LISTENER: yes
# KAFKA_ZOOKEEPER_CONNECT: zookeeper:2181
# KAFKA_CFG_AUTO_CREATE_TOPICS_ENABLE: true
# KAFKA_CFG_LISTENERS: L1://:8080,L2://:8081
# KAFKA_CFG_ADVERTISED_LISTENERS: L1://127.0.0.1:8080,L2://kafka:8081,
# KAFKA_CFG_LISTENER_SECURITY_PROTOCOL_MAP: L1:PLAINTEXT,L2:PLAINTEXT
# KAFKA_CFG_INTER_BROKER_LISTENER_NAME: L2

# steps:
# - uses: actions/checkout@v3
# - uses: ./.github/actions/setup-python-matrix

# # Special case packages
# - name: Install librdkafka-dev
# run: |
# # Use lsb-release to find the codename of Ubuntu to use to install the correct library name
# sudo apt-get update
# sudo ln -fs /usr/share/zoneinfo/America/Los_Angeles /etc/localtime
# sudo apt-get install -y wget gnupg2 software-properties-common
# sudo wget -qO - https://packages.confluent.io/deb/7.2/archive.key | sudo apt-key add -
# sudo add-apt-repository "deb https://packages.confluent.io/clients/deb $(lsb_release -cs) main"
# sudo apt-get update
# sudo apt-get install -y librdkafka-dev/$(lsb_release -c | cut -f 2)

# - name: Get Environments
# id: get-envs
# run: |
# echo "::set-output name=envs::$(tox -l | grep "^${{ github.job }}\-" | ./.github/workflows/get-envs.py)"
# env:
# GROUP_NUMBER: ${{ matrix.group-number }}

# - name: Test
# run: |
# tox -vv -e ${{ steps.get-envs.outputs.envs }}
# env:
# TOX_PARALLEL_NO_SPINNER: 1
# PY_COLORS: 0

# - name: Upload Coverage Artifacts
# uses: actions/upload-artifact@v3
# with:
# name: coverage-${{ github.job }}-${{ strategy.job-index }}
# path: ./**/.coverage.*
# retention-days: 1

mongodb:
env:
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ commands =
framework_grpc: --grpc_python_out={toxinidir}/tests/framework_grpc/sample_application \
framework_grpc: /{toxinidir}/tests/framework_grpc/sample_application/sample_application.proto

libcurl: pip install --ignore-installed --install-option="--with-openssl" pycurl
libcurl: pip install --ignore-installed --config-settings="--build-option=--with-openssl" pycurl

py.test -v []

Expand Down