Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes that prevented mongodb-3.1 from applying when the asyn… #635

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

jasonjkeller
Copy link
Contributor

…c/reactive client was present.

This essentially reverts changes from #476 that resulted in the mongodb-3.1 instrumentation no longer applying if the async/reactivestreams clients were also being used.

After further investigation it doesn't appear that the mongodb-3.1 instrumentation is causing the same token timeout issues that the mongodb-3.7 instrumentation was.

This will result in instrumentation applying for uses of the mongodb sync client version 3.1.0 and above once again.

Resolves: #560

@twcrone
Copy link
Contributor

twcrone commented Jan 6, 2022

Looks straightforward

@jasonjkeller jasonjkeller merged commit 1406322 into main Jan 6, 2022
@jasonjkeller jasonjkeller deleted the revert-mongodb-sync branch January 6, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

MongoDB instrumentation won't apply to the sync client if async/reactivestreams client is also present
3 participants