issue #344 completable future tokens not expired correctly #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-gibson
commented
Jan 4, 2022
| @@ -2,8 +2,6 @@ import com.nr.builder.JarUtil | |||
|
|
|||
| evaluationDependsOn(":newrelic-agent") // This is important because we need newrelic-agent to be configured before functional_test so the correct ("unversioned") jar name gets used | |||
|
|
|||
| apply plugin: 'scala' | |||
There was a problem hiding this comment.
scala plugin not needed for functional tests
jasonjkeller
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
CompletableFutures instrumentation currently creates tokens whenever a CompletableFuture is created. We assume that CF will be completed, whether success or error. When completed, we catch all the finish points to expire our token.
New implementation only creates Tokens on execution of CompletionStage rather than creation of the Structure.
Token is expired on completion of Execution.
Related Github Issue
Resolves #344
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[Y] Are your contributions backwards compatible with relevant frameworks and APIs?
[N] Does your code contain any breaking changes? Please describe.
[N] Does your code introduce any new dependencies? Please describe.