SqlObfuscator does not obfuscate certain html documents #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiao
commented
Jan 4, 2022
| parameters.put(1, "String1"); | ||
| parameters.put(2, 1.0f); | ||
| parameters.put(3, 1); | ||
|
|
There was a problem hiding this comment.
This map was never used.
twcrone
approved these changes
Jan 4, 2022
meiao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When recreating a "raw" query from a PreparedStatement, the values from the params were added to the "raw" query without escaping any quotes inside of it.
This caused some problems later on when the obfuscator would try to match the quotes to remove any value in the query.
Fixed by escaping single quotes (unless it was already escaped using a
\) prior to adding values to the "raw" query.Related Github Issue
#568
Testing
Tests were added to verify the quotes were being properly escaped.
Checks
[Y] Are your contributions backwards compatible with relevant frameworks and APIs?
[N] Does your code contain any breaking changes? Please describe.
[N] Does your code introduce any new dependencies? Please describe.