cats effect 3: pass transaction info by implicits #578
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before contributing, please read our contributing guidelines and code of conduct.
Overview
This is a change to the newrelic scala cats 3 api. The change ensures transaction and current token information is passed by parameters rather than ThreadLocal variables. Parameters used are implicit, this helps to keep API changes to a minimum
Related Github Issue
Include a link to the related GitHub issue, if applicable
#406
Testing
The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
Checks
[N] Are your contributions backwards compatible with relevant frameworks and APIs?
A small breaking change was necessary for the Cats Effect 3 API.
now becomes
[ Y] Does your code contain any breaking changes? Please describe.
See above
[ N] Does your code introduce any new dependencies? Please describe.