Spans auto app name #566
Merged
Spans auto app name #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XiXiaPdx
force-pushed
the
spans-auto-app-name
branch
2 times, most recently
from
db0e217 to
6d13914
Compare
twcrone
force-pushed
the
spans-auto-app-name
branch
from
f9e6857 to
a0cb10b
Compare
twcrone
force-pushed
the
spans-auto-app-name
branch
from
787fcd7 to
62093c1
Compare
twcrone
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for #124
Manual testing, spans are generated and associated with the correct app names. The code research and how the agent works in this scenario is documented here - https://docs.google.com/document/d/1QR9qMqfSA2ILtmGzgkxe6OdSN9knVHOx8e5tid91_MY/edit?usp=sharing
AIT: 🟢 https://javaagent-build.pdx.vm.datanerd.us/job/AIT_Configurable/231/
Additional PR for AITS to add test coverage: https://source.datanerd.us/java-agent/agent-integration-tests/pull/66
The sample app has a base name and creates two Auto App name transactions. The expected behavior is that spans should report to the associate transaction, on the the particular auto app name, which is happening here.
This is broken behavior, where all spans of all app names report to the base app name.