🌶 Ignore sysprop formatted envvars and log the correct variable name #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-nr
suggested changes
Aug 28, 2020
There was a problem hiding this comment.
Can we please add a test case that confirms that a poorly formatted item from the environment does NOT make it into the result? These kinds of documentation-style tests are helpful to the future reader who wants to quickly understand how this code works.
Might be as simple as putting that test back into place and changing the assertions to show that those properties do NOT exist?
breedx-nr
changed the title
breedx-nr
approved these changes
Aug 28, 2020
tspring
deleted the
newrelic/ignore_dot_delimited_environment_variables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38