Fix okhttp dependency clash #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so they don't clash with customers' dependencies
meiao
changed the title
jasonjkeller
approved these changes
Jun 15, 2021
meiao
added a commit
that referenced
this pull request
Jun 15, 2021
so they don't clash with customers' dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
On the 7.0.0 release, an indirect dependency to okhttp (4.8) was introduced to the agent.
This dependency was not shadowed, so it shared the same namespace of any customers' dependencies to older versions of okhttp, which caused errors on their end.
This commit instructs the shadower to change those classes so they are in a different namespace (package).
As an added bonus, this will also prevent the weaver to change these classes.
Related Github Issue
Resolves #324
Testing
This change cannot be tested in this project, as it requires different versions of the same dependency to be loaded at the same time.
Checks
[Y] Are your contributions backwards compatible with relevant frameworks and APIs?
[N] Does your code contain any breaking changes? Please describe.
[N] Does your code introduce any new dependencies? Please describe.