Pekko scala3 #2163
Merged
Pekko scala3 #2163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2163 +/- ##
============================================
+ Coverage 70.66% 70.69% +0.03%
- Complexity 9964 10002 +38
============================================
Files 840 842 +2
Lines 40251 40348 +97
Branches 6106 6115 +9
============================================
+ Hits 28442 28526 +84
- Misses 9065 9072 +7
- Partials 2744 2750 +6 ☔ View full report in Codecov by Sentry. |
jasonjkeller
approved these changes
Dec 10, 2024
|
|
||
| private String getTransactionPrefix() { | ||
| return "WebTransaction/PekkoHttp"; | ||
| } |
There was a problem hiding this comment.
~1700 lines of tests. That's thorough!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2109
This PR adds support for pekko http on scala 3.
It's a lift of our existing pekko http module for scala 2.13, with a few return type tweaks.
There are unit tests and AITs that will be merged after. I also tested this quite a bit locally with sample apps, it's working as expected.
(Note that the pekko AITs are currently excluded from the AITs test suite so they won't run below. I ran them here to verify they will work when reenabled. I will have another PR in the lineup to turn them back on).