Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only log if superagent is enabled #2156

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Only log if superagent is enabled #2156

merged 2 commits into from
Nov 26, 2024

Conversation

jtduffy
Copy link
Contributor

@jtduffy jtduffy commented Nov 25, 2024

Only log SuperAgent related info if the SA is in fact enabled.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.85714% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.70%. Comparing base (4431da3) to head (0437e5d).

Files with missing lines Patch % Lines
...com/newrelic/agent/service/ServiceManagerImpl.java 12.50% 6 Missing and 1 partial ⚠️
...agent/superagent/SuperAgentIntegrationService.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2156      +/-   ##
============================================
- Coverage     70.74%   70.70%   -0.04%     
+ Complexity    10006    10000       -6     
============================================
  Files           842      842              
  Lines         40346    40348       +2     
  Branches       6115     6115              
============================================
- Hits          28542    28529      -13     
- Misses         9054     9066      +12     
- Partials       2750     2753       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jtduffy jtduffy merged commit 6a2de60 into main Nov 26, 2024
111 checks passed
@jtduffy jtduffy deleted the sa-log-fix branch November 26, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants